Skip to content

changed isFunction to be private #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
radelmann wants to merge 1 commit into
base: master
Choose a base branch
from
Open

changed isFunction to be private #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions reunderscore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,18 @@
return typeof list === 'object';
}

/**
* returns true if object is a function
* @param {object} object
* @return {Boolean}
*/
function isFunction(object) {
if (typeof object === 'function') {
return true;
}
return false;
}

/**
* Iterates over list invoking callback fn on each item
* @param {Object|array} list
Expand All @@ -41,11 +53,11 @@
_.each = function(list, fn) {
if (isArray(list)) {
for (var i = 0; i < list.length; i++) {
fn(list[i]);
fn(list[i], i, list);
}
} else if (isObject(list)) {
for (var key in list) {
fn(list[key]);
fn(list[key], key, list);
}
}
};
Expand Down Expand Up @@ -254,7 +266,7 @@
var result = [];
for (var i = 0; i < list.length; i++) {
var item = list[i];
if (_.isFunction(item[methodName])) {
if (isFunction(item[methodName])) {
result.push(item[methodName].apply(item));
}
}
Expand Down Expand Up @@ -283,7 +295,7 @@
*/
_.max = function(list, fn) {
var value, result;
if (_.isFunction(fn)) {
if (isFunction(fn)) {
for (var i = 0; i < list.length; i++) {
var itemValue = fn(list[i]);
if (i === 0) {
Expand Down Expand Up @@ -316,7 +328,7 @@
*/
_.min = function(list, fn) {
var value, result;
if (_.isFunction(fn)) {
if (isFunction(fn)) {
for (var i = 0; i < list.length; i++) {
var itemValue = fn(list[i]);
if (i === 0) {
Expand Down Expand Up @@ -345,7 +357,7 @@
* @return {Array}
*/
_.sortBy = function(list, iteratee) {
if (_.isFunction(iteratee)) {
if (isFunction(iteratee)) {
//sort by iteratee fn
return list.sort(function(a, b) {
return iteratee(a) - iteratee(b);
Expand All @@ -372,7 +384,7 @@
_.groupBy = function(list, iteratee) {
var result = {};
var value, i;
if (_.isFunction(iteratee)) {
if (isFunction(iteratee)) {
for (i = 0; i < list.length; i++) {
value = iteratee(list[i]);

Expand Down Expand Up @@ -535,17 +547,6 @@
return false;
};

/**
* returns true if object is a function
* @param {object} object
* @return {Boolean}
*/
_.isFunction = function(object) {
if (typeof object === 'function') {
return true;
}
return false;
};

/**
* returns array of numbers based on start, end and step values
Expand Down