Add more base types and type aliases.#1254
Open
NoahStoryM wants to merge 1 commit intoracket:masterfrom
Open
Conversation
Member
|
Yes, anything that can appear printed should be legal to write. |
061b2e7 to
aa05640
Compare
Contributor
Author
|
Hi @jackfirth, |
Contributor
|
@NoahStoryM The Resyntax integration is broken for pull requests from forks. I'll have to rework the check so that the analysis step and the pull request comment step are split into different workflows. Feel free to ignore the failures for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more type aliases (see also #1242):
And here is something I'm not sure how to deal with:
TR reference says "Number and Complex are synonyms.", but
Exact-NumberandExact-Complexare different, is there any special reason? Should I modify it and regardExact-Complexas an alias forExact-Number?[edit]:
Exact-Complexshould not contain numbers like 0+1i, 1+0i, etc..I notice that there are some types defined in
rep/base-types.rktandrep/numeric-base-types.rktand REPL already uses them, but they are not provided. Should TR provide them?