This repository was archived by the owner on Feb 15, 2022. It is now read-only.
[CDN-1153] Add change to delete a change in progress#29
Open
merryldmello wants to merge 1 commit into
Open
Conversation
…ress/under pending changes in CPS. poppy/distributed_task/taskflow/task/delete_service_tasks.py removed flavor_id as cert_obj will contain required details to be passed on. poppy/distributed_task/taskflow/task/delete_ssl_certificate_tasks.py removed flavor_id and added cert_obj_json which is passed from delete_service_tasks.py which will contain all required details including cert_details which is needed to delete pending change in progress. If cert_obj_json is present, the notification will be sent for an actual delete of a pending change or a deletion of an existing domain, which earlier would have thrown up an error through mailgun tests/unit/distributed_task/taskflow/test_flows.py added additional cert_details to the certificate object as we need to delete a pending change which would be present in the actual certificate object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDN-1153
Add change to delete a change when it is in create_in_progress/under pending changes in CPS.
Earlier pending change was skipped, and this has been addressed in the current change.