fix(ui): add cursor-pointer to Button base#118
Merged
Conversation
Tailwind v4 preflight sets cursor: default on <button>, so all enabled buttons lost the pointer cursor on hover. Add cursor-pointer to the shared Button base classes (disabled buttons keep pointer-events-none, so they're unaffected). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cursor: defaulton<button>, so every enabled button in the app lost its pointer cursor on hover. This addscursor-pointerto the shared shadcnButtonbase classes — fixing it app-wide in one place.Changes
src/components/ui/button.tsx— addcursor-pointerto the basecvastring.Notes
disabled:pointer-events-none, so the pointer doesn't show on disabled state (no change there).asChild/link usages (rendered as<a>) already had pointer; this is harmless there.Test plan
Generated with Claude Code