fix(proposals): show duplicate banner in preview by rendering description as Markdown#110
Merged
Merged
Conversation
…tion as Markdown Replace plain text split with <Markdown> in ProposalPreview so the preview renders identically to the published proposal detail page. If the user accidentally pastes the banner image into the description, they will see it duplicated in the preview and can fix it before submitting.
|
@mtlouzada is attempting to deploy a commit to the r4to's projects Team on Vercel. A member of the Team first needs to authorize it. |
The preview wrapped <Markdown> in an extra `prose prose-gray max-w-none` div, but Markdown already renders its own `prose prose-neutral dark:prose-invert` container. This nested two prose contexts and applied a light-only palette over a dark-aware one. Remove the wrapper so the preview renders through a single prose context — matching ProposalDescriptionCard on the published proposal page. Verified in the running app: markdown (headings, links, images, lists, tables) renders identically, nested prose eliminated (2 -> 1 wrapper), and malicious description input stays sanitized (no script/onerror/js:). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
split("\n\n")with<Markdown>inProposalPreviewso the preview renders identically to the published proposal detail pageChanges
src/components/proposals/ProposalPreview.tsx— swapsplit("\n\n")for<Markdown>componentTest plan
into the description fieldGenerated with Claude Code