Add Must variants and named Identity constructors#36
Merged
Conversation
Convenience helpers for callers that hold a well-formed transaction and don't want to thread errors from the unreachable failure paths in Digest/ID. MustID reuses MustDigest internally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The isLowerCase boolean on Identity.FromPubKey is a semantic flag, not a real parameter: lowercase=true means tx ID, lowercase=false means address. Named constructors make intent explicit at call sites and remove the misuse risk of passing the wrong bool. Transaction.ID/MustID now delegate to the new helpers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transaction.MustDigest()andTransaction.MustID()— panic-on-error variants ofDigest/IDfor callers that hold a well-formed transaction.NewTxID(digest)/NewAddress(pubKey)constructors and theirMustNewTxID/MustNewAddressvariants. These wrapIdentity.FromPubKeyand replace the semantic boolean (isLowerCase=true→ tx ID,false→ address) with named intent at call sites.Transaction.ID/MustIDto delegate to the new helpers.Existing
Identity.FromPubKey/ToPubKeyremain for back-compat; this PR is additive.Test plan
go test ./types/...— all tests pass (including new TDD-first tests:TestTransaction_MustDigest_MatchesDigest,TestTransaction_MustID_MatchesID,TestNewAddress_MatchesFromPubKeyUppercase,TestNewTxID_MatchesFromPubKeyLowercase,TestMustNewAddress_MatchesNewAddress,TestMustNewTxID_MatchesNewTxID)go vet ./types/...cleango build ./types/...clean🤖 Generated with Claude Code