Skip to content

Conversation

@fnordspace
Copy link
Contributor

  • Adds Oracles to the core
  • Remove dependency from QBAY and NOSTROMO to QUOTTERY datetime
  • Solves issue with Unions for non-MSVC
  • Fix revenue of computors to 100% due to potential mid-epoch updates
  • Increase ADDITION_SOLUTION_THRESHOLD_DEFAULT to 74196

philippwerner and others added 30 commits November 18, 2025 18:23
- add all QPI stubs, support user procedures for notification
- docs Price / oracle interfaces
- fix typos
- fix test
+ some docs and minor changes
IDs do not contain the contract ID in order to better use the available
bits.
@fnordspace fnordspace moved this to 👀 In review in qubic Feb 10, 2026
Copy link
Collaborator

@Franziska-Mueller Franziska-Mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! maybe check if we want to lower the new initial tick, it's quite far in the future currently.

my other comments are rather minor and can be fixed after epoch transition as well.

struct NOST : public ContractBase
{
public:
/****** PORTED TIMEUTILS FROM OLD Nostromo *****/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make them protected instead of public?


struct QBAY : public ContractBase
{
/****** PORTED TIMEUTILS FROM OLD QUOTTERY *****/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, make it protected

{
private:
unsigned long long executionFeeReports[contractCount][NUMBER_OF_COMPUTORS];
unsigned long long executionFeeReports[contractCount][NUMBER_OF_COMPUTORS];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the indentation is broken now in this file

@fnordspace fnordspace merged commit bcc5531 into main Feb 11, 2026
2 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in qubic Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants