feat(cli): git auto initialization on creation#8800
Conversation
e89421b to
6f38be0
Compare
|
@IlCallo |
|
Sorry, I cannot understand what is the problem, can you provide us an example? Consider that Quasar CLI is pretty much the only one which still doesn't auto initialise a git repo upon project creation. |
|
@IlCallo not for every project I create project with quasar in app folder, then create repo in root directory (myproject) and push to github |
|
I tend to agree that this should be a question asked to the user, just like the "use yarn or npm". At work, this would have caused issues, because the client is deep inside a mono-repo. |
I see... But the vast majority of the community wouldn't follow your workflow, and standards should support the majority.
Putting it on CLI has technical motivations: I initially implemented it as an option on starter kit, but since we have multiple starter kits, we would need to replicate the same code on all of them, so Razvan asked me to move it in the CLI. Nested monorepo should surely be supported, what do you think of preventing the git init if we find a |
|
I think it is always best to ask the User what they want. Put a question into the project setup questions as only the User will know, at that time, what they need. |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch and not themasterbranchfix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Needs quasarframework/quasar-starter-kit#150, quasarframework/quasar-starter-kit-app-extension#18 and quasarframework/quasar-starter-kit-ui#53 to work.
As discussed into quasarframework/quasar-starter-kit#148
This will work only if
completefunction from the starter kit is a Promise to preserve backwards compatibility with custom starter kits