This repository was archived by the owner on Mar 13, 2022. It is now read-only.
feat: Added noscript notice to index.template.html#68
Open
yusufkandemir wants to merge 3 commits into
Open
Conversation
|
Lighthouse checks that there is such a message in PWA so 👍 |
Blfrg
reviewed
Sep 10, 2020
Contributor
Blfrg
left a comment
Blfrg
left a comment
There was a problem hiding this comment.
Please consider the change recommended here.
Co-authored-by: Blfrg <i3lfrg@gmail.com>
yusufkandemir
force-pushed
the
feat-add-noscript-notice-to-index.html-template
branch
from
646030a to
2d42b94
Compare
Contributor
|
The most recent recommendation has been implemented (current variable used). |
Member
|
@rstoenescu told me there could be problems and left this out on purpose. We'll wait until he can check this and write why it's better to leave it out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch and not themasterbranchOther information:
Inspired from Vue CLI.