Skip to content

[backport] use npm: prefix in import map for lodash #13864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cderv merged 3 commits into from
Jan 14, 2026
Merged

[backport] use npm: prefix in import map for lodash #13864

cderv merged 3 commits into from
Jan 14, 2026
+31 −19

Conversation

@cderv
Copy link
Collaborator

@cderv cderv commented Jan 9, 2026

Important

Backport PR #13850

I think we need this for v1.8 dev version to build on CI.

See problem in #13858

@cderv
use npm: prefix in import map for lodash (#13850)
ba04fc8 
* dev: use npm: prefix in import map for lodash as skypack CDN is failing with error 500
* fix: add type annotations for lodash npm: import compatibility

The npm: prefix for lodash doesn't preserve generic type inference,
causing TypeScript to infer `any` for callback parameters. Added
explicit type annotations and type assertions where needed.

(cherry picked from commit d341f2a)
@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented Jan 9, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@cderv cderv mentioned this pull request Jan 9, 2026
Open
cderv added 2 commits January 14, 2026 11:49
@cderv
Render this test without koma script
64920d8 
This avoid failing test while still testing the feature

(cherry picked from commit 98a0a0f)
@cderv
test - temporary opt out some article layout test due to latex update…
2c06c5b 
… issues

Something in recent LaTeX updates appears to have broken some of the article layout tests.
Rendering them make them hangs.

To temporarily opt out these tests until we can investigate and fix the underlying issue, #13663

(cherry picked from commit dd8d141)
@cderv cderv merged commit b6b491f into v1.8 Jan 14, 2026
44 checks passed
@cderv cderv deleted the backport/skypack-fix branch January 14, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cderv @posit-snyk-bot