-
Notifications
You must be signed in to change notification settings - Fork 396
feat(listings): customise pagination options for website listings #13126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mcanouil
wants to merge
11
commits into
quarto-dev:main
Choose a base branch
from
mcanouil:feat/issue12031-listing-pagination
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(listings): customise pagination options for website listings #13126
mcanouil
wants to merge
11
commits into
quarto-dev:main
from
mcanouil:feat/issue12031-listing-pagination
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
fa98912 to
bfef90b
Compare
Enhance the existing listing test suite by adding pagination tests to verify the presence of pagination elements and their expected behaviour in the rendered output.
a58b65b to
d9b15fd
Compare
Collaborator
Author
|
This PR is finally ready with appropriate tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for custom pagination options in listings, allowing users to define parameters such as inner and outer window sizes. This enhancement improves flexibility in displaying paginated content.
Options from https://listjs.com/docs/pagination/
Default is unchanged but could be customised: