DO NOT MERGE: tws cluster fast find pairs #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdales
reviewed
Aug 5, 2024
methods/matching/calculate_k.py
Outdated
| # RasterLayer.layer_from_file(os.path.join(ecoregions_directory_path, filename)) for filename in | ||
| # glob.glob("*.tif", root_dir=ecoregions_directory_path) | ||
| # ], name="ecoregions") | ||
| ecoregions = RasterLayer.layer_from_file(ecoregions_directory_path) |
Contributor
There was a problem hiding this comment.
This looks like somehow @swinersha has based his work off the work-in-progress branch I have for per-project optimisation, rather than from main. But he doesn't seem have picked up any other changes oddly enough. I was worried I'd accidentally committed something I shouldn't to main, but that doesn't appear to be the case.
Removed the problematic lines for ecoregion and access
Uncommented lines needed for ecoregion and access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental branch where:
At the moment we are looking for feedback and plan to do some experiments to compare the resulting matches and additionality with those from the current version on main. There are definitely places where the code can be improved.