Some clean up#48
Open
Alexis Cellier (fhost) wants to merge 7 commits into
Open
Conversation
Alexis Cellier (fhost)
force-pushed
the
fhost/cleanup
branch
from
b197691 to
bba8038
Compare
Contributor
|
Alexis Cellier (@fhost) - DCO is failing. Can you update your commits using DCO ? You can attest to the DCO by committing with the -s or --signoff options or manually adding the "Signed-off-by": |
This fixes gbp buildpackage. Signed-off-by: Alexis Cellier <alexis.cellier@canonical.com>
.gitignore file has no reason to be installed. Signed-off-by: Alexis Cellier <alexis.cellier@canonical.com>
The module is already loaded by the soft dependency added though modprobe.d configuration file. Signed-off-by: Alexis Cellier <alexis.cellier@canonical.com>
dh_dkms is automatically adding a trigger to call it. Signed-off-by: Alexis Cellier <alexis.cellier@canonical.com>
A package should not add some configuration in /etc. Also, use a hook to only include the module. It will be loaded by the dependency specified in modprobe.d configuration. Signed-off-by: Alexis Cellier <alexis.cellier@canonical.com>
This is handle by dkms. Signed-off-by: Alexis Cellier <alexis.cellier@canonical.com>
We need some linux-headers, but not the generic one. The correct headers should already be installed (linux meta packages are here for that). Also, there is no need for grub. This avoid installing useless packages. Signed-off-by: Alexis Cellier <alexis.cellier@canonical.com>
Alexis Cellier (fhost)
force-pushed
the
fhost/cleanup
branch
from
bba8038 to
76e9a39
Compare
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.