feat: add RISC-V 64-bit JIT backend#147
Closed
CN-TangLin wants to merge 3 commits into
Closed
Conversation
3b38182 to
2197a55
Compare
qmonnet
requested changes
May 29, 2026
qmonnet
left a comment
Owner
There was a problem hiding this comment.
Hi, and thanks!
I haven't been through the code in details yet, but please:
- Drop the formatting changes from your first commit, they don't seem relevant and they make it harder to review. If they come from rustfmt, I'm OK to take them, but as a separate commit.
- Motivate the change in the second commit. Why do you need the
jitmodule to be public? (The reason should also appear in the commit description)
The `jit` module is made public because it allows external crates (such as OS kernels integrating rbpf) to access the JIT compiler and structures like `JitMemory` directly, enabling custom JIT memory management or AOT compilation scenarios.
2197a55 to
5036199
Compare
Owner
|
Thanks, the split will make it easier to review. I haven't had time to go through the details of the backend yet. One question: Did you notice that there is a (not-really-documented) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a complete RISC-V 64-bit (rv64) backend for the JIT compiler.
Key Features
BPF_DIVandBPF_MOD.Testing
#[cfg(target_arch = "riscv64")]specific unit tests for instruction generation validation.Looking forward to your review!