fix: cast i32 to u32 first for zero ext#138
Merged
Merged
Conversation
qmonnet
requested changes
Feb 5, 2026
qmonnet
left a comment
qmonnet
left a comment
Owner
There was a problem hiding this comment.
Looks good, thanks for the fix, and for the tests!
Can you please sign-off your commit?
Signed-off-by: hsqStephenZhang <stephenzhang666666@gmail.com>
hsqStephenZhang
force-pushed
the
fix/i32_cast
branch
from
5cd273b to
4d30e17
Compare
Contributor
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should cast i32 value to u32 first for zero extension.
The fix is quite straight forward, the test cases are added. It will panic before the fix.