Add cargo build and rename preview MCP tools#3
Conversation
|
Warning Review limit reached
Your plan currently allows 1 review/hour. Refill in 36 minutes and 20 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe PR adds two new MCP tools to the Rust Analyzer MCP server: ChangesRename Preview and Cargo Build Tools
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 5: The README currently says all `ra_*` tools are readonly but includes
`ra_set_workspace` which mutates server state; update the sentence to split into
two parts: list readonly analysis/edit-preview tools (e.g., `ra_hover`,
`ra_definitions`, `ra_references`, `ra_document_symbols`, `ra_completions`,
formatting edits, code actions, `ra_rename_preview`, diagnostics, workspace
diagnostics) and separately call out state-changing workspace control like
`ra_set_workspace` as a mutating operation that switches server workspace;
ensure `ra_rename_preview`, formatting and code action tools are explicitly
described as preview-only and do not mutate files, while `ra_set_workspace` is
described as performing state changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: ce951627-330f-4a34-b2b3-0a7d14656039
📒 Files selected for processing (10)
README.mdsrc/cargo/args.rssrc/cargo/params.rssrc/lsp/client.rssrc/ra/edits.rssrc/ra/params.rssrc/server/mod.rssrc/tools.rstests/cargo_tests.rstests/integration_basic.rs
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test (windows-latest)
🔇 Additional comments (20)
README.md (1)
7-7: LGTM!Also applies to: 217-230, 252-277, 283-283, 296-296, 347-347, 405-405, 430-433, 449-449
src/tools.rs (1)
11-12: LGTM!src/cargo/args.rs (1)
11-11: LGTM!Also applies to: 94-95, 117-117
src/cargo/params.rs (1)
20-20: LGTM!Also applies to: 81-81
tests/cargo_tests.rs (1)
27-27: LGTM!Also applies to: 53-60, 63-85, 92-92, 100-101, 328-340
src/server/mod.rs (1)
25-25: LGTM!Also applies to: 30-30, 592-679, 814-830
src/ra/params.rs (3)
72-78: LGTM!
93-102: LGTM!
108-144: LGTM!src/ra/edits.rs (4)
1-33: LGTM!
35-74: LGTM!
76-90: LGTM!
92-168: LGTM!src/lsp/client.rs (3)
17-20: LGTM!
227-241: LGTM!
329-361: LGTM!tests/integration_basic.rs (4)
86-138: LGTM!
176-194: LGTM!
204-319: LGTM!
321-382: LGTM!
Summary
cargo_buildsupport with structured args, including release buildsra_rename_previewMCP toolcargo_buildandra_rename_previewin the root READMETest Plan
cargo fmt --checkgit diff --checkcargo clippy --all-targets --all-features -- -D warningscargo test --allcargo test --test integration_basic mcp_tools_list_smoke_has_mvp_tools_and_protocol_stdout -- --nocapturecargo test --test cargo_tests argument_construction -- --nocaptureNotes
docs/remains gitignored and untracked.Summary by CodeRabbit
New Features
ra_rename_previewtool to preview rename edits before applying themcargo_buildtool for building Rust projects--releaseflag support for cargo commandsDocumentation