Bump to React 16#54
Conversation
|
Hi @qimingweng , if you could accept this PR would be very nice! Thank you and thank @SandroMachado ! |
| "react": "^0.14.0 || ^15.0.0", | ||
| "react-dom": "^0.14.0 || ^15.0.0" | ||
| "react": "16.0.0", | ||
| "react-dom": "16.0.0", |
There was a problem hiding this comment.
This will still work with react 15.6, you should expand the version range to be more permissive.
Something like 15.x || ^16.0.0 would be better.
The react & prop-types peerDependencies should also be more lenient.
|
Until this PR gets merged I have forked this repo and committed the built library so it can be used as a dependency. "react-modal-dialog": "Dean177/react-modal-dialog#support\/bump-react", |
|
This package also depends on |
|
@Dean177 what is blocking this PR from merge? |
|
No idea, I think you want @qimingweng rather than me though. |
|
@qimingweng hey, man! we would love to see this PR already! |
|
Could also use this merged. Thanks! |
|
Looking forward to having this merged 😄 |
|
bump can @qimingweng please merge! |
This PR adds support to React 16.