Skip to content

Bump to React 16#54

Open
SandroMachado wants to merge 1 commit into
qimingweng:masterfrom
uphold-forks:support/bump-react
Open

Bump to React 16#54
SandroMachado wants to merge 1 commit into
qimingweng:masterfrom
uphold-forks:support/bump-react

Conversation

@SandroMachado

Copy link
Copy Markdown

This PR adds support to React 16.

@rafaeleyng

Copy link
Copy Markdown

Hi @qimingweng , if you could accept this PR would be very nice!

Thank you and thank @SandroMachado !

Comment thread package.json
"react": "^0.14.0 || ^15.0.0",
"react-dom": "^0.14.0 || ^15.0.0"
"react": "16.0.0",
"react-dom": "16.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will still work with react 15.6, you should expand the version range to be more permissive.
Something like 15.x || ^16.0.0 would be better.

The react & prop-types peerDependencies should also be more lenient.

@Dean177

Dean177 commented Oct 30, 2017

Copy link
Copy Markdown

Until this PR gets merged I have forked this repo and committed the built library so it can be used as a dependency.
You can use it by changing the relevant line in your package.json to

"react-modal-dialog": "Dean177/react-modal-dialog#support\/bump-react",

@jeron-diovis

jeron-diovis commented Feb 16, 2018

Copy link
Copy Markdown

This package also depends on react-center-component. Same author, and all the same problems. That package also should be updated to make react-modal-dialog usable with react@16.

@SandroMachado

Copy link
Copy Markdown
Author

@Dean177 what is blocking this PR from merge?

@Dean177

Dean177 commented Feb 16, 2018

Copy link
Copy Markdown

No idea, I think you want @qimingweng rather than me though.

@ilyadoroshin

Copy link
Copy Markdown

@qimingweng hey, man! we would love to see this PR already!

@pippinlee

Copy link
Copy Markdown

Could also use this merged. Thanks!

@ttbarnes

Copy link
Copy Markdown

Looking forward to having this merged 😄

@ali-aka-ahmed

Copy link
Copy Markdown

bump can @qimingweng please merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants