fix(time/weather): fix freeze logic and dynamic weather countdown logic#91
Open
aysihuniks wants to merge 2 commits into
Open
fix(time/weather): fix freeze logic and dynamic weather countdown logic#91aysihuniks wants to merge 2 commits into
aysihuniks wants to merge 2 commits into
Conversation
Member
|
These comments are off-topic and inappropriate for this repository. This serves as a formal warning. No further comments are required on this pull request. Any further inappropriate or disruptive behaviour may result in more comments being removed and additional moderation action. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Pull request
Fixed a critical math logic bug in
client.lua(tick - 22 > tick) that was breaking time synchronization across players. Also fixed a thread loop interval issue inserver.luawhere the weather countdown was ticking down way slower than the configuredConfig.NewWeatherTimer.If your PR is to fix an issue mention that issue here
These changes fix the issues where /time and /weather admin commands wouldn't update or sync properly.
Questions (please complete the following information):