Skip to content

Conversation

@NickJLange
Copy link

Summary

I'm not sure why the current build script has the current logic, but to compile on an aarch64 VM for deployment to a rpi4, we need to use the right cross-compiler. This fixes the selection. Hopefully in dialogue the original logic will emerge.

Test plan

Built on a Debian Bookworm VM (Large) for deployment to a Debian RPI4 (Small)

I'm not sure why the current build script has the current logic, but
to compile on an aarch64 VM for deployment to a rpi4, we need to use
the right cross-compiler.
Copilot AI review requested due to automatic review settings January 21, 2026 06:29
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 21, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16734

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit aded0c9 with merge base 4c8132c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Jan 21, 2026

Hi @NickJLange!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the cross-compiler selection logic to enable building on aarch64 VMs (like Debian Bookworm Large) for deployment to Raspberry Pi 4 devices. The original code incorrectly mapped aarch64 hosts to use x86_64 cross-compilers, preventing proper compilation.

Changes:

  • Separated aarch64 architecture detection into its own case to correctly download aarch64-hosted cross-compilers
  • Removed aarch64 from the x86_64 architecture group

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 22, 2026 05:36
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant