-
Notifications
You must be signed in to change notification settings - Fork 806
Allow building aarch64 (Large VM, Debian) for a rpi4 deployment #16734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Allow building aarch64 (Large VM, Debian) for a rpi4 deployment #16734
Conversation
I'm not sure why the current build script has the current logic, but to compile on an aarch64 VM for deployment to a rpi4, we need to use the right cross-compiler.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16734
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit aded0c9 with merge base 4c8132c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @NickJLange! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the cross-compiler selection logic to enable building on aarch64 VMs (like Debian Bookworm Large) for deployment to Raspberry Pi 4 devices. The original code incorrectly mapped aarch64 hosts to use x86_64 cross-compilers, preventing proper compilation.
Changes:
- Separated aarch64 architecture detection into its own case to correctly download aarch64-hosted cross-compilers
- Removed aarch64 from the x86_64 architecture group
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
I'm not sure why the current build script has the current logic, but to compile on an aarch64 VM for deployment to a rpi4, we need to use the right cross-compiler. This fixes the selection. Hopefully in dialogue the original logic will emerge.
Test plan
Built on a Debian Bookworm VM (Large) for deployment to a Debian RPI4 (Small)