-
Notifications
You must be signed in to change notification settings - Fork 807
Arm backend: Add as_strided_copy.default decomposition and test #16702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Change-Id: Iffedfed51bba0ef63524b0aed7ce63c36881eaea Signed-off-by: Xingguo Li <xingguo.li@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16702
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit aabdc73 with merge base dbf3c37 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "ciflow/trunk" |
|
To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page). This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
@pytorchbot label "partner: arm" |
|
@pytorchbot label "release notes: arm" |
|
This got a test error with |
|
@zingo Probably unrelated to my PR. That failure is in test_mobilenet_v2_arm.py::test_mv2_tosa_FP_channels_last and complains that torch.ops.higher_order.executorch_call_delegate is missing in the lowered graph. My PR changes as_strided_copy decomposition and support logic; it doesn’t touch the mobilenet test, delegate lowering, or call-delegate op insertion. |
|
@zingo I don't think I have that level of permission, can't even trigger workflow.... |
|
Was going to retrigger it for you but it seem to already be running. |
|
Test rerun 4 time and still fails, Ill try a rebase also, if that don't work it might be something in the test anyway. |
|
@zingo found the culprit will create a chained patch on top, the culprit is that I need to delete L67-L71 in /backends/arm/test/models/test_mobilenet_v2_arm.py https://github.com/pytorch/executorch/blob/main/backends/arm/test/models/test_mobilenet_v2_arm.py#L58 |
Good find!!! Anmd nice outcome that we lowered more in this case :) |
…_strided_copy support Change-Id: Id2601033105fe8e8af1e908712cb8c2ab2659821 Signed-off-by: Xingguo Li <xingguo.li@arm.com>
1e21bcd to
aabdc73
Compare
zingo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to merge if all Arm tests passes ( they do :) )


Change-Id: Iffedfed51bba0ef63524b0aed7ce63c36881eaea
Summary
Arm backend: Add as_strided_copy.default decomposition and test
@zingo @per @freddan80 @oscarandersson8218 @Sebastian-Larsson
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai