Skip to content

Conversation

@xingguo01
Copy link
Contributor

@xingguo01 xingguo01 commented Jan 20, 2026

Change-Id: Iffedfed51bba0ef63524b0aed7ce63c36881eaea

Summary

Arm backend: Add as_strided_copy.default decomposition and test

@zingo @per @freddan80 @oscarandersson8218 @Sebastian-Larsson

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

Change-Id: Iffedfed51bba0ef63524b0aed7ce63c36881eaea
Signed-off-by: Xingguo Li <xingguo.li@arm.com>
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 20, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16702

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit aabdc73 with merge base dbf3c37 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 20, 2026
@xingguo01
Copy link
Contributor Author

@pytorchbot label "ciflow/trunk"

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 20, 2026

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@xingguo01
Copy link
Contributor Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jan 20, 2026
@xingguo01
Copy link
Contributor Author

@pytorchbot label "release notes: arm"

@pytorch-bot pytorch-bot bot added the release notes: arm Changes to the ARM backend delegate label Jan 20, 2026
@zingo
Copy link
Collaborator

zingo commented Jan 20, 2026

This got a test error with
FAILED backends/arm/test/models/test_mobilenet_v2_arm.py::test_mv2_tosa_FP_channels_last
Not sure if the tests is just randomely failing or related to the PR, if you think is a random fail you can just retrigger the failed test and it will probably go away.

@xingguo01
Copy link
Contributor Author

@zingo Probably unrelated to my PR. That failure is in test_mobilenet_v2_arm.py::test_mv2_tosa_FP_channels_last and complains that torch.ops.higher_order.executorch_call_delegate is missing in the lowered graph. My PR changes as_strided_copy decomposition and support logic; it doesn’t touch the mobilenet test, delegate lowering, or call-delegate op insertion.

@zingo
Copy link
Collaborator

zingo commented Jan 20, 2026

If you click on the "pull / unittest-arm-backend-..." below

image

You will get to test output, you can look at the error and if you scroll all the way to the top again you have a drop-down called "Re-run jobs" on the top right side. If you select "Re-run failed jobs" it will only rerun those.

image

@xingguo01
Copy link
Contributor Author

@zingo I don't think I have that level of permission, can't even trigger workflow....

@zingo
Copy link
Collaborator

zingo commented Jan 20, 2026

Was going to retrigger it for you but it seem to already be running.

@zingo
Copy link
Collaborator

zingo commented Jan 20, 2026

Test rerun 4 time and still fails, Ill try a rebase also, if that don't work it might be something in the test anyway.
Test seem to pass on main
https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=arm-backend
So lets see after the rebase tests has finished :)

@xingguo01
Copy link
Contributor Author

@zingo found the culprit will create a chained patch on top, the culprit is that I need to delete L67-L71 in /backends/arm/test/models/test_mobilenet_v2_arm.py https://github.com/pytorch/executorch/blob/main/backends/arm/test/models/test_mobilenet_v2_arm.py#L58

@zingo
Copy link
Collaborator

zingo commented Jan 20, 2026

@zingo found the culprit will create a chained patch on top, the culprit is that I need to delete L67-L71 in /backends/arm/test/models/test_mobilenet_v2_arm.py https://github.com/pytorch/executorch/blob/main/backends/arm/test/models/test_mobilenet_v2_arm.py#L58

Good find!!! Anmd nice outcome that we lowered more in this case :)

…_strided_copy support

Change-Id: Id2601033105fe8e8af1e908712cb8c2ab2659821
Signed-off-by: Xingguo Li <xingguo.li@arm.com>
@xingguo01 xingguo01 force-pushed the arm-backend-as_strided_copy branch from 1e21bcd to aabdc73 Compare January 20, 2026 23:24
Copy link
Collaborator

@zingo zingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge if all Arm tests passes ( they do :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants