Skip to content

Conversation

@ares89
Copy link
Contributor

@ares89 ares89 commented Jan 20, 2026

Summary

Fixes #16535

feat(backends/qualcomm): add support for SA8797/SA8397 chipset and V81 architecture

Test plan

I have tested the changes by compiling and running a model on the SA8397 with QNN SDK v2.42.0.251225
python examples/qualcomm/oss_scripts/llama/llama.py -b build-android -m SA8797 --temperature 0 --model_mode hybrid --max_seq_len 1024 --prefill_ar_len 128 --decoder_model qwen3-0_6b --compile_only --prompt "what is 1+1" --checkpoint /home/xxx/.cache/meta_checkpoints/Qwen_Qwen3-0.6B.pth --artifact ./llama_qnn/qwen3/8797_04

python examples/qualcomm/oss_scripts/llama/llama.py -b build-android -m SA8797 -s localhost:5555 --decoder_model qwen3-0_6b --model_mode hybrid --prefill_ar_len 128 --max_seq_len 1024 --prompt "what is 1+1" --pre_gen_pte D:\\tmp\\llama_qnn_qwen3_06b\\8797_04

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 20, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16695

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 21 Pending

As of commit bba3ce5 with merge base 4c8132c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 20, 2026
@kirklandsign
Copy link
Contributor

Hello @ares89 do you intend to merge to main or release/1.0?

@ares89
Copy link
Contributor Author

ares89 commented Jan 20, 2026

Hello @ares89 do you intend to merge to main or release/1.0?

I want to merge to main, and I'll test the recent changes

@ares89
Copy link
Contributor Author

ares89 commented Jan 20, 2026

@kirklandsign
I have tested the changes on the main branch, and it is working fine.

@SS-JIA
Copy link
Contributor

SS-JIA commented Jan 20, 2026

cc: @cccclai @shewu-quic @chunit-quic @haowhsu-quic @winskuo-quic since this is a QNN backend related update!

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me, will wait to see if qcom folks have more feedback

@cccclai
Copy link
Contributor

cccclai commented Jan 21, 2026

Hmm somehow the CI is not triggered. Can I get some help to land this PR? @SS-JIA @Gasoonjia @JacobSzwejbka

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign
Copy link
Contributor

Hmm somehow the CI is not triggered. Can I get some help to land this PR? @SS-JIA @Gasoonjia @JacobSzwejbka

Tried update branch and seems working

@cccclai
Copy link
Contributor

cccclai commented Jan 22, 2026

@ares89 the lint runner is failing, can you fix the error?

 Lint for backends/qualcomm/serialization/qc_schema.py:

  Warning (UFMT) format
    Run `lintrunner -a` to apply this patch.

    You can run `lintrunner -a` to apply this patch.

    69  69 | 
    70  70 | _soc_info_table = {
    71  71 |     QcomChipset.SA8295: SocInfo(QcomChipset.SA8295, HtpInfo(HtpArch.V68, 8)),
    71     |-    QcomChipset.SA8797: SocInfo(QcomChipset.SA8797, HtpInfo(HtpArch.V81, 16)),
        72 |+    QcomChipset.SA8797: SocInfo(QcomChipset.SA8797, HtpInfo(HtpArch.V81, 16)),
    73  73 |     QcomChipset.SM8350: SocInfo(QcomChipset.SM8350, HtpInfo(HtpArch.V68, 4)),
    74  74 |     QcomChipset.SM8450: SocInfo(QcomChipset.SM8450, HtpInfo(HtpArch.V69, 8)),
    75  75 |     QcomChipset.SM8475: SocInfo(QcomChipset.SM8475, HtpInfo(HtpArch.V69, 8)),

@ares89
Copy link
Contributor Author

ares89 commented Jan 22, 2026

@ares89 the lint runner is failing, can you fix the error?

fixed ^_^

@cccclai cccclai merged commit 176c162 into pytorch:main Jan 22, 2026
144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add support SA8397 SoC (automotive) in executorch Qualcomm backend

4 participants