[mypyc] Fix __init_subclass__ running before ClassVar instantiations#20916
Merged
JukkaL merged 2 commits intopython:masterfrom Mar 6, 2026
Merged
[mypyc] Fix __init_subclass__ running before ClassVar instantiations#20916JukkaL merged 2 commits intopython:masterfrom
__init_subclass__ running before ClassVar instantiations#20916JukkaL merged 2 commits intopython:masterfrom
Conversation
JukkaL
approved these changes
Mar 5, 2026
Collaborator
JukkaL
left a comment
There was a problem hiding this comment.
Thanks, looks good. I have just one minor code quality suggestion.
mypyc/irbuild/classdef.py
Outdated
Collaborator
There was a problem hiding this comment.
Can you remove the | None part here, which would let you skip the is not None check below? It looks like this is always not-None.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review, done! Thought I had went over exactly that and deemed None necessary, not sure why..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#1086
We also ran into this in SQLGlot; To compile our AST we swapped any metaclasses for
__init_subclass__in which we dynamically set some attributes in it like so:I introduced the
InitSubclassprimitive to allow for fine-grained control of when this gets called and moved it fromExtClassBuilder::__init__(i.eallocate_class > CPyType_FromTemplate) toExtClassBuilder::finalize