Skip to content

gh-143304: Fix ctypes.CDLL to honor handle parameter on POSIX systems #143318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Koolvansh07 wants to merge 7 commits into
base: main
Choose a base branch
from
Open

gh-143304: Fix ctypes.CDLL to honor handle parameter on POSIX systems #143318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8634db5
Fix ctypes.CDLL to honor handle parameter on POSIX systems
Koolvansh07 Dec 31, 2025
bb4c92e
Add NEWS entry for gh-143304
Koolvansh07 Dec 31, 2025
d8b9ed3
Address review feedback
Koolvansh07 Jan 1, 2026
32eb34d
Move handle check to beginning to avoid unnecessary computation
Koolvansh07 Jan 1, 2026
6d95eff
Remove debug files that were accidentally committed
Koolvansh07 Jan 1, 2026
d3f65b6
Move handle check to end of function as suggested by reviewer
Koolvansh07 Jan 1, 2026
cdb8f6e
Update test assertion to match (actual, expected) convention
Koolvansh07 Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/ctypes/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,8 @@ def _load_library(self, name, mode, handle, winmode):
if name and name.endswith(")") and ".a(" in name:
mode |= _os.RTLD_MEMBER | _os.RTLD_NOW
self._name = name
if handle is not None:
return handle
return _dlopen(name, mode)

def __repr__(self):
Expand Down
8 changes: 8 additions & 0 deletions Lib/test/test_ctypes/test_loading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,14 @@ def test_load_without_name_and_with_handle(self):
lib = ctypes.WinDLL(name=None, handle=handle)
self.assertIs(handle, lib._handle)

@unittest.skipIf(os.name == "nt", 'POSIX-specific test')
@unittest.skipIf(libc_name is None, 'could not find libc')
def test_load_without_name_and_with_handle_posix(self):
lib1 = CDLL(libc_name)
handle = lib1._handle
lib2 = CDLL(name=None, handle=handle)
self.assertIs(lib2._handle, handle)

@unittest.skipUnless(os.name == "nt", 'Windows-specific test')
def test_1703286_A(self):
# On winXP 64-bit, advapi32 loads at an address that does
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2026-01-01-05-26-00.gh-issue-143304.Kv7x9Q.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix :class:`ctypes.CDLL` to honor the ``handle`` parameter on POSIX systems.
Loading