Allow HttpResponseProtocol.url to be read only
#1511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django’s `HttpResponseRedirect` does not satisfy the old protocol, because its `url` property is read-only. https://github.com/typeddjango/django-stubs/blob/5.2.8/django-stubs/http/response.pyi#L138-L139 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1511 +/- ##
==========================================
- Coverage 79.00% 78.99% -0.01%
==========================================
Files 354 354
Lines 11510 11509 -1
Branches 526 526
==========================================
- Hits 9093 9092 -1
Misses 2236 2236
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django’s
HttpResponseRedirectdoes not satisfy the old protocol, because itsurlproperty is read-only.https://github.com/typeddjango/django-stubs/blob/5.2.8/django-stubs/http/response.pyi#L138-L139