Include xa-datasource statistics to app metrics#652
Open
raimdev wants to merge 2 commits intopython-diamond:masterfrom
raimdev:jboss-xa-datasources
Open
Include xa-datasource statistics to app metrics#652raimdev wants to merge 2 commits intopython-diamond:masterfrom raimdev:jboss-xa-datasources
raimdev wants to merge 2 commits intopython-diamond:masterfrom
raimdev:jboss-xa-datasources
Conversation
shortdudey123
requested changes
May 16, 2017
src/collectors/jbossapi/jbossapi.py
Outdated
| current_user = matches.group(1) | ||
| current_pword = matches.group(2) | ||
|
|
||
| return tmp_result.group(1) | ||
|
|
||
| def collect(self): | ||
|
|
Member
|
Still needs tests added for the metric |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current jbossapi collector fetch only data-sources skipping xa-data-sources, in this commit I included xa-data-sources for metrics