Add JSON response type for AccumulationTable and RecursionTable#1362
Merged
Conversation
Collaborator
Coverage Report for CI Build 28639487168Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 90.931%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
david-yz-liu
reviewed
Jul 1, 2026
david-yz-liu
left a comment
david-yz-liu
left a comment
Contributor
There was a problem hiding this comment.
Nice work @a1-su, I left a few inline comments, and also:
- Great point about the
csvformat forRecursionTable. I'm okay expanding the scope of this PR to also updatingRecursionTableto support file output (which you've already done) and supporting thecsvformat. You can add a separate entry in the Changelog about these changes. - In addition to creating tests for the new functionality, please also update the documentation to reflect the changes.
| - Update configuration options to support `.toml` files | ||
| - Updated plain text and HTML PyTA reports to not show sections with no errors and only show 'good job' message once when there are no errors in either section. | ||
| - Added `snapshots` property to `SnapshotTracer` to make captured snapshot data available through the public API. | ||
| - Added `json` response formats to `AccumulationTable` and `RecursionTable` |
| self.function_name = set(function_name) | ||
| self.frames_data = {} | ||
| self._trees = {} | ||
| self.output_filepath = output |
Contributor
There was a problem hiding this comment.
Add documentation and type annotations for these instance attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR adds the JSON response type format for the
AccumulationTableandRecursionTable, which both previously only supported the table format and CSV format.Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)
RecursionTabledoes not support CSV return formats unlike theAccumulationTable, which I can add as well if needed