Add PTZ calibration app and calibrated move parameters#335
Open
MateoLostanlen wants to merge 4 commits intodevelopfrom
Open
Add PTZ calibration app and calibrated move parameters#335MateoLostanlen wants to merge 4 commits intodevelopfrom
MateoLostanlen wants to merge 4 commits intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #335 +/- ##
===========================================
- Coverage 79.97% 72.59% -7.39%
===========================================
Files 7 7
Lines 824 602 -222
===========================================
- Hits 659 437 -222
Misses 165 165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When the target angle is below the calibrated bias at speed 1, fire a 50ms impulse instead of skipping the move. Applies to both /click_to_move and /move endpoints. Add micro-pulse calibration section to the calibration app (zoom 41 default for precision).
Add duration parameter to /move endpoint so move+sleep+stop happens on the Pi. Update calibration app to use single API calls for all movements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calibration app features