Update rust_toolchain, drop link_native_libs=no and bigint flags#86
Closed
hoodmane wants to merge 1 commit intopyodide:mainfrom
Closed
Update rust_toolchain, drop link_native_libs=no and bigint flags#86hoodmane wants to merge 1 commit intopyodide:mainfrom
hoodmane wants to merge 1 commit intopyodide:mainfrom
Conversation
We don't need these anymore
hoodmane
commented
Jan 15, 2025
| "meson_cross_file": str(TOOLS_DIR / "emscripten.meson.cross"), | ||
| # Rust-specific configuration | ||
| "rustflags": "-C link-arg=-sSIDE_MODULE=2 -C link-arg=-sWASM_BIGINT -Z link-native-libraries=no", | ||
| "rustflags": "-C link-arg=-sSIDE_MODULE=2", |
Member
Author
There was a problem hiding this comment.
Actually, I guess this will make building for existing versions annoying. I'll leave these defaults here and just set RUSTFLAGS in Makefile.envs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need these anymore. link_native_libs=no was fixed by:
rust-lang/libc#4002
and wasm_bigint was fixed by:
rust-lang/rust#131736