Security: Unsafe np.load with allow_pickle=True in NPZFile#607
Open
tomaioo wants to merge 1 commit into
Open
Conversation
The NPZFile class uses np.load with allow_pickle=True, which can execute arbitrary code when loading maliciously crafted NPZ files. This is a known security vulnerability in NumPy's loading mechanism that allows for remote code execution through pickled objects. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Unsafe np.load with allow_pickle=True in NPZFile
Problem
Severity:
High| File:pynapple/io/interface_npz.py:L78The NPZFile class uses np.load with allow_pickle=True, which can execute arbitrary code when loading maliciously crafted NPZ files. This is a known security vulnerability in NumPy's loading mechanism that allows for remote code execution through pickled objects.
Solution
Consider using allow_pickle=False if the use case permits, or implement strict validation of file contents before loading. If pickle support is required, document the security implications and consider adding warnings or sandboxing.
Changes
pynapple/io/interface_npz.py(modified)