utc time#603
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
format_timestampsandreturn_timestampsmethods inpynapple/core/time_index.pyto simplify their logic and improve clarity. The main change is to return the timestamp arrays directly for seconds without rounding, and to return immediately in each conditional branch, removing redundant code.Refactoring and simplification:
format_timestamps: Now returns the input array directly when units are seconds ("s"), and only applies rounding for milliseconds ("ms") and microseconds ("us"). The function now returns immediately in each branch, eliminating unnecessary variable assignments and the final return statement.return_timestamps: Similarly, now returns the input array directly for seconds, and immediately returns the appropriately converted and rounded arrays for milliseconds and microseconds. This also removes redundant code and improves readability.