Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses several edge-case bugs and improves robustness in the jitted core functions, especially when handling empty input arrays or single-element cases. It also adds comprehensive tests to cover these cases and documents the fixes in the release notes.
Bug fixes in jitted core functions:
jitrestrict,jitrestrict_with_count,jitin_interval,jitremove_nan,jitthreshold, andjitunion_isetswhen called with empty time arrays or empty epoch sets. These previously led to random crashes or segfaults with Numba JIT enabled, orIndexErrorwith JIT disabled. Now, these functions return appropriate empty outputs. [1] [2] [3] [4] [5] [6]jitrestrict_with_countandjitin_intervalwhen all epoch ends are before the first timestamp. [1] [2]jitthresholdto correctly handle single-element input arrays, preventing out-of-bounds access.nan_condvariable injitvaluefromfor epochs containing exactly one target timestamp and mode isbeforeorclosest, ensuring correctNaNresults instead of silent errors.compute_perievent(viajitvaluefrom) crash onTsGroupinputs when any event has no spikes within the requested window.Testing improvements:
Documentation:
doc/releases.mdto summarize all the bug fixes and improvements included in this patch.