fix#601
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of the
jitrestrictandjitrestrict_with_countfunctions by adding explicit handling for empty input arrays, and introduces new tests to ensure correct behavior for these edge cases.Core logic improvements
jitrestrictandjitrestrict_with_count(inpynapple/core/_jitted_functions.py) to immediately return empty results when the input time array or epochs are empty, preventing potential errors or unnecessary computation. [1] [2]Testing enhancements
tests/test_jitted.pyto verify thatjitrestrictandjitrestrict_with_countcorrectly handle empty time arrays and empty epochs, ensuring these functions return empty outputs as expected in these scenarios.