Issue 155: single source of version, setuptools -> flit#239
Open
jpreszler wants to merge 2 commits intopymc-labs:mainfrom
Open
Issue 155: single source of version, setuptools -> flit#239jpreszler wants to merge 2 commits intopymc-labs:mainfrom
jpreszler wants to merge 2 commits intopymc-labs:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 73.89% 73.89%
=======================================
Files 19 19
Lines 1149 1149
=======================================
Hits 849 849
Misses 300 300 |
Collaborator
|
Just checking that this is still a draft PR? When it's ready can you get me and @lucianopaz to review? |
914cf4c to
628db3b
Compare
Contributor
Author
|
@drbenvincent and @lucianopaz , I've cleaned this up and it's ready for review. I looked into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve issue #155 , but I couldn't get setuptools to do dynamic versioning because of the imports in
__init__.py. Switching to flit seems to work with minimal changes.I tested by changing the version locally and using
pip install -e .in a clean environment. The version was correct. Also usingpython -m buildproduced targ.gz and whl files with the correct versions in names.Not sure if other testing would be good or if there's further discussion needed before changing the backend build system.