feat: Add changes and corner cases to allow casbin-redis-watcher to work with flask authz and redis 5#16
Closed
favipcj wants to merge 2 commits intopycasbin:masterfrom
Closed
Conversation
added 2 commits
September 20, 2024 15:41
…ts disconnected or other cause + create separted redis connections to make it work with redis5
Author
|
hey @hsluoyz when you get a chance, could you please take a look at these changes and let me know if changes are required ? |
Author
|
Can we please have a review on this PR @hsluoyz ? |
Author
|
closed in favor of apache/casbin-python-redis-watcher#3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature description
This PR covers corner cases that are needed when using flask-authz, specifically:
should_reloadandupdate_callbackmethods that flask-authz needs https://github.com/pycasbin/flask-authz/blob/master/flask_authz/casbin_enforcer.py#L66-L67subscribemethod to show message errors related to redis and close the redis connection before the thread is killedTo make this library work with any Python library Redis version including redis 5, a different instance of the Redis class was created for the subscriber and publisher, as that is required for Redis 5 and still works for other old versions as well.
CI/Unit test Running https://github.com/favipcj/redis-watcher/actions/runs/10965417424. Only a minor change was added to the ci workflow to only release builds in the master branch