[Repo Assist] fix: return p_value=1 when refuter simulations have zero variance (closes #807)#1454
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
…loses #807) When all refuter simulations return the same value, std_dev is zero, causing division by zero and a NaN p-value. Guard against this degenerate case: log a warning and return 1.0, meaning the original estimate is indistinguishable from the simulation distribution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Member
|
/repo-assist please fix the linter errors in this commit (see build errors) |
Contributor
Author
|
✗ Repo Assist encountered failed, see workflow run. |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated fix from Repo Assist.
Closes #807
Root Cause
perform_normal_distribution_testindowhy/causal_refuter.pycomputes a z-score by dividing by the standard deviation of the refuter simulations:No new lint errors introduced (pre-existing line-length warnings in the file are unrelated to this change).