Add possibility to forbid orientation within same tier in BackgroundKnowledge #253
+73
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nowledge Signed-off-by: Ykabrit <ykabrit@yanibou.fr>
Collaborator
|
Thanks a lot for the great contribution! To also let others benefit from this more directly, could you please add a test case in https://github.com/py-why/causal-learn/blob/main/tests/TestBackgroundKnowledge.py to showcase the usage? |
Signed-off-by: Ykabrit <ykabrit@yanibou.fr>
…kgroundKnowledge Signed-off-by: Ykabrit <ykabrit@yanibou.fr>
Contributor
Author
|
I added a test case as you requested, |
kunwuz
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new attribute to
BackgroundKnowledge, calledforbidden_within_tiers, which is a set of integers that correspond to tiers within which we forbid all orientation.Methods
forbid_within_tierandallow_within_tierare added to add and remove tiers from the new set. By default, the set is empty and orientation within tiers is allowed, as it was before.The method
is_forbiddenis slightly modified in order to check if the two nodes are from the same tier, and if it is the case and the tier is inforbidden_within_tiers, returnTrue.Tested using the PC algorithm.