Extract full data stream for misaligned access mode#72
Open
lionnus wants to merge 2 commits intopulp-platform:prasadar/multi-precisionfrom
Open
Extract full data stream for misaligned access mode#72lionnus wants to merge 2 commits intopulp-platform:prasadar/multi-precisionfrom
lionnus wants to merge 2 commits intopulp-platform:prasadar/multi-precisionfrom
Conversation
Member
|
LGTM except for a very minor thing: please align to 1/2 of https://github.com/pulp-platform/hci/blob/master/STYLE.md . HCI uses my own style, in part predating the lowrisc one to which it is very similar but not identical. |
lionnus
force-pushed
the
lkesting/multi-precision-fix
branch
from
c600e1d to
4a785a8
Compare
Author
|
Thank you @FrancescoConti, hope this works :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in misaligned data access: previously, only BANK_DATA_WIDTH was extracted instead of the full misaligned data stream width (DATA_WIDTH - BANK_DATA_WIDTH).