-
Notifications
You must be signed in to change notification settings - Fork 32
Update pulp-nn-mixed submodule #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughUpdated the submodule pointer for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Xeratec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please update the changelog. We do this for every PR we merge.
|
Thanks for implementing the requested changes. I will approve and merge the PR once all the tests pass. |
This PR updates the
pulp-nn-mixedsubmodule to include the fix for an illegal hardware loop configuration related to thepulp_zero_memutility function PR10. The updated submodule removes the MemoryFence() from the loop, allowing the compiler to correctly generate a valid HW loop and preventing illegal configurations.Added
Changed
pulp-nn-mixedsubmoduleFixed
PR Merge Checklist
develcommit and pointing todevel.CHANGELOG.mdfile has been updated.