Skip to content

Conversation

@marchioa
Copy link
Contributor

@marchioa marchioa commented Dec 19, 2025

This PR updates the pulp-nn-mixed submodule to include the fix for an illegal hardware loop configuration related to the pulp_zero_mem utility function PR10. The updated submodule removes the MemoryFence() from the loop, allowing the compiler to correctly generate a valid HW loop and preventing illegal configurations.

Added

  • nothing

Changed

  • pulp-nn-mixed submodule

Fixed

  • nothing

PR Merge Checklist

  1. The PR is rebased on the latest devel commit and pointing to devel.
  2. Your PR reviewed and approved.
  3. All checks are passing.
  4. The CHANGELOG.md file has been updated.
  5. If the docker was modified, change back its link after review.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 19, 2025

📝 Walkthrough

Walkthrough

Updated the submodule pointer for TargetLibraries/PULPOpen/third_party/pulp-nn-mixed to a newer commit and added a changelog entry. No code, API, runtime, or control flow changes.

Changes

Cohort / File(s) Summary
Submodule Update
TargetLibraries/PULPOpen/third_party/pulp-nn-mixed
Updated commit reference from b69ec23ec81595ebbec694f4a28d84022858af83 to a9b4aaf597c030ce24bf65a00b5f3ec84a1528c4.
Changelog
CHANGELOG.md
Added Unreleased entry: "Update submodule pulp-nn-mixed [#145]".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update pulp-nn-mixed submodule' accurately describes the main change—updating a submodule—and aligns with the changeset which only modifies the pulp-nn-mixed submodule pointer.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly explains the purpose of the change: updating the pulp-nn-mixed submodule to fix an illegal hardware loop configuration issue related to the pulp_zero_mem utility function.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@Xeratec Xeratec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please update the changelog. We do this for every PR we merge.

@Xeratec Xeratec added the Feature Addition of new features label Dec 24, 2025
@Xeratec Xeratec added this to the Release 0.2.1 milestone Dec 24, 2025
@Xeratec Xeratec added this to Deeploy Dec 24, 2025
@Xeratec Xeratec moved this to In review in Deeploy Dec 24, 2025
@Xeratec
Copy link
Member

Xeratec commented Jan 5, 2026

Thanks for implementing the requested changes. I will approve and merge the PR once all the tests pass.

@Xeratec Xeratec moved this from In review to Ready for Merge in Deeploy Jan 5, 2026
@Xeratec Xeratec merged commit 0b554e9 into pulp-platform:devel Jan 6, 2026
142 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Merge to Done in Deeploy Jan 6, 2026
@marchioa marchioa deleted the fix-zero-mem branch January 6, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Addition of new features

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants