feat: fire 'update' event and set 'edited' state on opacity change#1411
Open
themacboy wants to merge 5 commits into
Open
feat: fire 'update' event and set 'edited' state on opacity change#1411themacboy wants to merge 5 commits into
themacboy wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that changing the overlay opacity sets the
editedstate totrueand triggers the'update'event.Previously, geometric changes (translation, rotation, scale, distortion) correctly updated the
editedstatus totrueand fired the'update'event on theDistortableImageOverlayinstance. However, opacity modifications via_toggleOpacityand_setOpacitiesonly updated the DOM element without notifying consumers.Changes
this._overlay.edited = trueand fired the'update'event in_toggleOpacity()(DistortableImage.Edit.js).this._overlay.edited = trueand fired the'update'event in_setOpacities()(DistortableImage.Edit.js).Use Case
This allows developers to listen to the
'update'event on the overlay as a single source of truth for detecting any unsaved changes (whether geometric or visual) to an overlay on the map.