Skip to content

Add polygon to searched country/state#1258

Open
liryyy wants to merge 3 commits into
publiclab:mainfrom
liryyy:add-polygon-to-searched-country-state
Open

Add polygon to searched country/state#1258
liryyy wants to merge 3 commits into
publiclab:mainfrom
liryyy:add-polygon-to-searched-country-state

Conversation

@liryyy

@liryyy liryyy commented Oct 29, 2022

Copy link
Copy Markdown

Fixes #1250 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome

welcome Bot commented Oct 29, 2022

Copy link
Copy Markdown

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io

gitpod-io Bot commented Oct 29, 2022

Copy link
Copy Markdown

@liryyy

liryyy commented Oct 29, 2022

Copy link
Copy Markdown
Author

Hi @vanithaak , here is my changes for issue #1250.
Could you please have a look at it? Thank you so much.

@vanithaak

vanithaak commented Oct 29, 2022

Copy link
Copy Markdown
Contributor

Hi @liryyy, good job! looks good to me. If you could add a GIF, it would be helpful for the mentors, to make a review. What do you think?

@jywarren, please review @liryyy's pr. Thanks!

@jywarren

jywarren commented Nov 2, 2022

Copy link
Copy Markdown
Member

Wow, this looks really good! @vanithaak i was thinking, what if we made the polygon disappear after a few seconds? That way it doesn't interfere with your editing activities. Could we amend this with a setTimeout() and delete the polygon?

@liryyy great work here. You've done it just right, it seems. Can you upload a screencast video so we can confirm? Thanks!

@vanithaak

Copy link
Copy Markdown
Contributor

Great idea! I'll see what we can do. Thanks Jeff

@liryyy

liryyy commented Nov 11, 2022

Copy link
Copy Markdown
Author

@jywarren Thank you for your suggestion. Here is the video about the change that I made for this issue.

Leaflet.DistortableImage.Example.-.12.November.2022.mp4

@vanithaak

Copy link
Copy Markdown
Contributor

Hi @liryyy, thank you for the video. As Jeff mentioned, he would like us to add setTimeout(). I did try to add but I get an error in the geocode line inside the function. Would you please give a try ?

@proy03

proy03 commented Feb 6, 2023

Copy link
Copy Markdown

@liryyy Hey, I am a enthusiastic newcomer and I would love to contribute. Could you please guide me through the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add polygon to searched country/state (FTO)

4 participants