Skip to content

feat(upgrade): Implement detailed error reporting and robust testing#6

Merged
psywarrior1998 merged 4 commits intomainfrom
feature/detailed-error-handling
Aug 31, 2025
Merged

feat(upgrade): Implement detailed error reporting and robust testing#6
psywarrior1998 merged 4 commits intomainfrom
feature/detailed-error-handling

Conversation

@psywarrior1998
Copy link
Copy Markdown
Owner

This commit introduces significant enhancements to the core upgrade logic
and testing suite to improve robustness and user feedback.

  • Refactors the upgrade_package worker to use subprocess.run instead
    of subprocess.check_call. This allows for capturing stdout and stderr.

  • Implements granular error handling by capturing the exact error message
    from pip upon a failed upgrade or a failed rollback.

  • Displays the captured error details to the user, providing clear,
    actionable feedback on why an operation failed.

  • Adds a comprehensive test suite for the upgrade_package worker,
    mocking subprocess.run to verify all execution paths:

    • Successful upgrade
    • Failed upgrade with successful rollback
    • Failed upgrade with failed rollback
    • Failed upgrade with --no-rollback enabled

@psywarrior1998 psywarrior1998 merged commit 5876d95 into main Aug 31, 2025
5 checks passed
@psywarrior1998 psywarrior1998 deleted the feature/detailed-error-handling branch August 31, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant