feat(messages): HeardPathMap in heard dialog for MT and MC (#304)#308
Merged
Conversation
Share path segment builder for traceroute and message heard maps.
Protocol-agnostic map with dashed paths when hop positions unknown.
Widen heard dialog; show sender, feeders, path hash badges for MeshCore.
Shared Leaflet marker CSS; mc_sender_candidates for map when unambiguous.
Overlay warning and draw listener markers without path lines.
When mc_sender_candidates has exactly one node, show its name with a link instead of Anonymous; multiple matches show label plus badge; group consecutive messages by inferred sender key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildSegmentsfromTracerouteMapfor reuse.HeardPathMap— sender + per-feeder legs with dashed lines whenpath_knownis false (MT always; MC v1 with hash tooltips).mc_sender_candidates/sender_positionwhen exactly one inferred node has coordinates; note when duplicate names match multiple nodes.messageSenderDisplay: 1 candidate → node name + link; 0 → Anonymous; >1 → parsed label + “N matches” badge; consecutive grouping uses inferred sender key.Depends on meshflow-api PR #370 (message
sender_position,heard[]path fields,mc_sender_candidates).Closes #304
Part of meshflow-api#267
Testing performed
npm run test(vitest, includingmessage-display-sender.test.ts)npm run buildmap-path-segments,heard-path-map-adapters,message-display-sender, existingTracerouteMappolyline tests