fix(meshcore): canonical MC channels across feeders (#379)#380
Merged
Conversation
Amend ADR-0002 and text-message-channels guide for #379: logical MessageChannel identity by name/hashtag, device index on link table only.
…nnel identity Introduce per-feeder slot mapping; merge duplicate canonical channels on migrate; drop mc_channel_idx from MessageChannel. Closes data model for #379.
Resolve ingest and device sync via ManagedNodeMcChannelLink; upsert MessageChannel by logical hashtag or public name.
Update serializers, admin, OpenAPI, and sync response for canonical channels with per-feeder mc_channel_idx on link rows.
Regression tests for shared hashtag across device indices and matching TextMessage.channel_id across feeders.
DxEventObservation.raw_packet referenced removed packets.rawpacket model, breaking migrate when building project state after the MT raw packet rename.
Document pre-prod message path gap (channel_text vs rx_log_data ADVERT), thin-bot/fat-server direction, and fix meshcore ingestion doc formatting. Gitignore Meshflow/ai-env for pre-prod DB skill.
4 tasks
Update phase-2 progress/outstanding, text-message-channels status table, and ADR-0002 UI note for ManagedNodeMcChannelLink model.
Introduce phase-3-progress.md and phase-3-outstanding.md under meshcore/, index them in README, and link from meshcore-path-progress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MessageChannelby name/hashtag) from per-feeder device slot (ManagedNodeMcChannelLinkwithmc_channel_idx).reconcile_mc_channelsandresolve_mc_channelnow map wirechannel_idx→ canonical channel so two feeders with#teston different slots share one row.display_labelon constellation channels andFeederMcChannelMirroron managed-nodemc_channels.heard[]lacks hops on channel text today), thin-bot/fat-server direction,meshcore.mdingestion tables clarified;Meshflow/ai-envgitignored for opt-in pre-prod DB skill.Related
Test plan
#test/Scotlandchannels merge as expected.#testat different indices → one canonicalMessageChannel, two links.python -m pytest Meshflow/meshcore_packets/tests/test_canonical_channels.py Meshflow/meshcore_packets/tests/test_channel_sync.py -vmc-channel-sync+ apply-mc-channel-config smoke test (no bot wire changes).