fix(meshcore): feeder WS presence, apply dispatch, and MC admin#335
Merged
Conversation
Match apply-mc-channel-config dispatch to the same ManagedNode as feeder-scoped HTTP ingest when API keys are shared (#295).
group_channels does not exist on channels-redis 4.x; probe
asgi:group:{name} like group_send does. Fixes false 503 when
Redis shows the bot subscribed.
Use plain PUBLIC/HASHTAG choice values instead of gettext labels and sanitize group_send payloads so channels_redis can serialize commands.
List MC type, hashtag, and feeder channel mirror with sync timestamp for operators debugging device channel sync and apply flows.
Add MeshCoreMessageChannel proxy admin with #hashtag labels, show device mirror read-only on ManagedNode, and admin action to push mirror via WS. Extract channel_apply service shared with the apply API endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #334 (merged) for staging/local MC channel apply and operator tooling:
feeder_bot_not_connected503).node_mc_{id}byfeeder_pubkey_prefixquery param when multiple feeders share an API key.apply_mc_channelspayloads (plain PUBLIC/HASHTAG strings,_ws_json_safeongroup_send).mc_channelsmirror andmc_channels_synced_at.Companion: meshflow-bot#108 (WS prefix + channel scan diagnostics).
Related #295
Testing performed
python -m pytest Meshflow/common/tests/test_feeder_ws.py Meshflow/meshcore_packets/tests/test_apply_channel.py Meshflow/ws/tests/test_mc_node_consumer.py -vapply-mc-channel-configreturns 202 with local API + pre-prod bot on shared RedisDeploy notes
Restart API workers after merge. No migrations.