fix(fmodata): align webhook types with FM OData API response#127
Merged
Conversation
…126) WebhookListResponse, WebhookInfo, WebhookAddResponse property names didn't match what FM OData API actually returns. Verified via e2e test against live server. Renames: Status→status, WebHook→webhooks, webHookID→webhookID, url→webhook, webHookResult→webhookResult. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@proofkit/better-auth
@proofkit/cli
create-proofkit
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #126
WebhookListResponse:Status→status,WebHook→webhooksWebhookInfo:webHookID→webhookID,url→webhookWebhookAddResponse:webHookResult→webhookResult, innerwebHookID→webhookIDscripts/verify-webhook-types.tse2e script that hits real API to verify types matchTest plan
verify-webhook-types.tsconfirms all types match real FM OData API🤖 Generated with Claude Code
Note
Medium Risk
This is a breaking, public API surface change: webhook response property names are renamed to match the real FileMaker OData responses, which will require downstream code updates. Runtime behavior is largely unchanged, but any consumers reading the old keys (or tests/fixtures relying on them) will break.
Overview
BREAKING: Webhook response typings now match the FM OData API’s actual JSON keys, renaming
WebhookListResponse(Status→status,WebHook→webhooks),WebhookInfo(webHookID→webhookID,url→webhook), andWebhookAddResponse(webHookResult.webHookID→webhookResult.webhookID).Docs/README examples, mock response fixtures, and webhook unit tests/scripts were updated to use the new property names, and a new
scripts/verify-webhook-types.tswas added to validate raw webhook endpoint responses against the TypeScript expectations.Written by Cursor Bugbot for commit c5efdbd. This will update automatically on new commits. Configure here.