Require pull requests for develop#1
Merged
Conversation
Document mandatory PR workflow in AGENTS.md, CODING_STANDARDS.md, and AGENT_RULES.md. Add a pull request template. Run Build and Test on PRs to develop (not on direct develop pushes).
sweetmans
force-pushed
the
chore/pr-workflow-policy
branch
from
451b732 to
cb67693
Compare
Use grep/find in all CI verification scripts so jobs pass without rg installed. Link Requirements/ from README.md. Scope preview coverage to public View types and fix PhotoPicker overlay naming.
Migrate PhotoPicker library and image loading from DispatchQueue to actors (PhotosLibraryExecutor, PhotoKitCoordinator). Add CI guard that fails on DispatchQueue and dispatch_* usage in Sources and Tests.
Replace build-and-test.yml with pr-checks.yml: governance on ubuntu-latest, macOS build/snapshots after governance passes. Add run_pr_checks.sh orchestrators, SwiftPM cache, cancel-in-progress concurrency, PR template, and include missing token/signing/sample-app guards. Finish rg removal in remaining verify scripts.
Fix macOS PR Checks failure when ripgrep is not installed on the runner.
Snapshot PNGs are for README and GitHub Pages only. Drop snapshot diff and manifest guards from CI; keep capture scripts for manual use.
Bring back GlassButtonStyle usage with iOS 26 availability fallback to .bordered. Delete the GitHub Actions PR Checks workflow and its orchestrator scripts; update docs to list manual verification commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces the team rule: no direct pushes to
develop. All work must land via pull request.Changes
AGENTS.md,CODING_STANDARDS.md, andDocs/AGENT_RULES.md.github/pull_request_template.mdBuild and Teston PRs targetingdevelop(removed directdeveloppush trigger)Repo settings (already applied on GitHub)
developbranch protection: require PR +build-teststatus checkenforce_admins: trueso admins also merge via PRChecklist
developdevelop