proposal: add proposal for issue/PR label convention#65
proposal: add proposal for issue/PR label convention#65jan--f wants to merge 4 commits intoprometheus:mainfrom
Conversation
jan--f
changed the title
jan--f
force-pushed
the
issue-pr-labels
branch
from
79b6366 to
6f7c5a7
Compare
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f
force-pushed
the
issue-pr-labels
branch
from
6f7c5a7 to
86fd9cc
Compare
beorn7
left a comment
beorn7
left a comment
There was a problem hiding this comment.
Looks good to me in general. However, I also don't feel very strongly about the details here. I guess once we see in in practice, we will see what works well and what needs changes. We shouldn't shy away from cutting out unused parts later. We have way too much label cruft already.
| This proposal targets: | ||
|
|
||
| - Prometheus maintainers who need to triage and review issues/PRs | ||
| - Contributors who need to understand the state of their submissions |
There was a problem hiding this comment.
Something about helping new contributors that are looking for issues to work on?
There was a problem hiding this comment.
I would still like such an addition here. WDYT?
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f
force-pushed
the
issue-pr-labels
branch
from
8c23d92 to
6aec48f
Compare
beorn7
left a comment
beorn7
left a comment
There was a problem hiding this comment.
Two smallish comments left.
In doubt, I would just go forward with this. We can always iterate on it.
In any case, it would be great if somebody else would look at this.
|
|
||
| **Usage**: Priority labels are typically assigned during triage and help maintainers and contributors understand what to work on first. Not all issues have priority labels assigned. | ||
|
|
||
| **Proposal**: Keep the labels and recommend to use as needed. |
There was a problem hiding this comment.
Maybe priority/Pmaybe can go (as it is essentially the inverse of triage/accepted). We historically introduced it as a nicer form of saying "no", but later it evolved into a truthful "we don't know yet if we want this", i.e. "absence of triage/accepted".
jan--f
force-pushed
the
issue-pr-labels
branch
from
64c33f8 to
e97d357
Compare
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f
force-pushed
the
issue-pr-labels
branch
from
e97d357 to
a3a38b8
Compare
2 participants
No description provided.