Conversation
|
Thanks for opening this pull request! Each pull request require an update in the CHANGELOG. Please update it based on your changes. |
This was undocumented and untested, and broke in 13.1.0. Fixes #499
@siimon @SimenB I'm somewhat inclined to not land this. This was undocumented and untyped, and it took 14 months for one user to notice this broke (between the time 13.1 was released and issue was opened). On the other hand, it's easy to support and the work is done. WDYT? |
|
I'm happy with reducing the API surface (i.e. not land this). However, we can throw an explicit error if an array is passed so the user is aware? |
|
getLabels isn't the hottest path in the code but it's kinda hot. If I'm reading this correctly, the index.d.ts signatures already exist in master now. Another variation on this is: This has been sitting this way for a long time now, do we still care? |
This was undocumented and untested, and broke in 13.1.0.
I'm not sure why we provide 4 ways to set labels.
Fixes #499