fix: correct public agent-card URLs shown to users#3
Open
Skyrider3 wants to merge 1 commit into
Open
Conversation
The public URL surfaced to users was wrong or 404'd in several places: - Personal card URLs are keyed by the user's handle (/personal/:handle/:slug.json), but the README intro example, the API table row, the identity-types prose, and the landing page all showed an email-based URL. The handle column is regex-constrained and can never equal an email, so following those examples 404s. Switch all of them to the handle format. - The dashboard rendered a copyable "Public URL" for every card, even ones flagged Private or Inactive. The server only serves a card when status='active' AND is_public=TRUE, so those URLs 404. Only show the URL (and Copy button) when the card is actually served publicly; otherwise show a muted note. - The edit-page banner gated on is_public but not status, so a public+inactive card still showed an "Open" link that 404s. Tighten it to is_public && active for consistency. No backend, route, or schema changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public URL surfaced to users was wrong or 404'd in several places:
No backend, route, or schema changes.