fix: make documented local-dev setup work without Docker#2
Open
Skyrider3 wants to merge 1 commit into
Open
Conversation
The README "Local development (without Docker)" flow could not complete on a fresh checkout: - migrate.ts resolved migrations from process.cwd()/db/migrations, but the SQL files live at src/db/migrations and `npm run migrate` runs from server/, so readdirSync threw ENOENT and no migrations applied. Resolve relative to this module first, falling back to the cwd layout the Docker image uses (unchanged: tsc does not emit .sql into dist/, so the container still uses /app/db/migrations). - .env.example defined no DATABASE_URL, which config.ts hard-requires (process.exit(1)), so `npm run dev`/`npm run migrate` exited FATAL on a copied .env. Add it; Docker Compose injects its own value, so this line only affects bare-metal runs. - seed.ts usage comment pointed at port 5433; docker-compose publishes Postgres on host port 5434.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README "Local development (without Docker)" flow could not complete on a fresh checkout:
npm run migrateruns from server/, so readdirSync threw ENOENT and no migrations applied. Resolve relative to this module first, falling back to the cwd layout the Docker image uses (unchanged: tsc does not emit .sql into dist/, so the container still uses /app/db/migrations).npm run dev/npm run migrateexited FATAL on a copied .env. Add it; Docker Compose injects its own value, so this line only affects bare-metal runs.